linux-kernel - Re: [PATCH CHAR-MISC-NEXT 1/4] Intel MIC Host Driver Sysfs Cleanups.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Sep 2013 20:15:21 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Sudeep Dutt <sudeep.dutt@...el.com>
Cc:	Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, Nikhil Rao <nikhil.rao@...el.com>,
	Ashutosh Dixit <ashutosh.dixit@...el.com>,
	Dasaratharaman Chandramouli 
	<dasaratharaman.chandramouli@...el.com>,
	Harshavardhan R Kharche <harshavardhan.r.kharche@...el.com>,
	"Yaozu (Eddie) Dong" <eddie.dong@...el.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
Subject: Re: [PATCH CHAR-MISC-NEXT 1/4] Intel MIC Host Driver Sysfs Cleanups.

On Thu, Sep 26, 2013 at 06:09:51PM -0700, Sudeep Dutt wrote:
> + Use DEVICE_ATTR_RO/RW instead of DEVICE_ATTR
> + Use ATTRIBUTE_GROUPS
> 
> These changes were suggested by Greg Kroah-Hartman during the
> code review @ https://lkml.org/lkml/2013/9/6/13
> 
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@...el.com>
> Signed-off-by: Dasaratharaman Chandramouli <dasaratharaman.chandramouli@...el.com>
> Signed-off-by: Nikhil Rao <nikhil.rao@...el.com>
> Signed-off-by: Harshavardhan R Kharche <harshavardhan.r.kharche@...el.com>
> Signed-off-by: Sudeep Dutt <sudeep.dutt@...el.com>
> ---

Ok, new kernel developer 101 training time :)

Your Subject:, while the [PATCH] part is fine the rest of the line needs
to be a bit more descriptive.

As this is the "mic" subsystem, how about something like:
	Subject: [PATCH 1/4] misc: mic: host driver sysfs cleanups

No need for the whole "Intel MIC" stuff.

Also, as I "reported" this, you should have a:
	Reported-by: Greg Kroah-Hartman <...>
line in the patch.

And really, all of those people reviewed and signed off on the patch?
That's great, just not a normal thing.

So, can you resend these 4 patches with those things cleaned up?  Same
thing goes for Joe's patch, he deserves a "Reported-by:" at the very
least, given that he pretty much wrote that whole patch.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/