linux-kernel - Re: [RFC PATCH] mfd: arizona: Update device tree regulator bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 28 Sep 2013 16:53:08 +0100
From:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	devicetree@...r.kernel.org, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] mfd: arizona: Update device tree regulator bindings

On Thu, Sep 26, 2013 at 06:58:43PM +0100, Mark Brown wrote:
> I don't see why this would only be an issue for ASoC - it happens to
> have more helpers for this right now than anything else but I'd hope
> that at some point in the future we can get some of the common patterns
> for holding regulators into the device framework.  You also have the
> potential for this to do the wrong thing if it doesn't happen to be
> talking to an MFD which is doing this since it just unconditionally
> looks at the parent.
> 
> I would suggest that rather than unconditionally doing this on lookup
> it'd be easier to do it the other way round and explicitly add mappings
> from the parent to the child when registering the device.  That doesn't
> have the potential to explode and get the wrong thing like this does.

Been a bit delayed on this as I have been investigating the
situation a little further. Is it just moving the supplies of the
parent node we object to? Or do we want to keep everything tidied
onto the one device tree node? The reason I ask is because
looking at this further we run into other problems, the MFD
framework is clearly intended to have a sub-node for each device.

For example, the GPIO driver has a similar issue if anything else
wishes to use an Arizona devices GPIO, because the GPIO driver
is on a different device to the MFD so again it can't locate it.
I haven't checked yet but I am guessing there will be similar
issues with the interrupts.

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/