linux-kernel - Re: [PATCH] misc: cs5535-mfgpt: Replace 'module_init' with 'module_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 28 Sep 2013 20:54:55 +0200
From:	richard -rw- weinberger <richard.weinberger@...il.com>
To:	elad.wexler@...il.com
Cc:	Arnd Bergmann <arnd@...db.de>,
	Greg KH <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] misc: cs5535-mfgpt: Replace 'module_init' with 'module_platform_driver'

On Sat, Sep 28, 2013 at 8:14 PM,  <elad.wexler@...il.com> wrote:
> From: Elad Wexler <elad.wexler@...il.com>
>
> Driver doesn't do anything special in 'module_init'.
>
> 'module_platform_init' makes the code more readable.
>
> Signed-off-by: Elad Wexler <elad.wexler@...il.com>

NAK.

By moving to module_platform_init() you make this module unloadable.
Currently it is unloadable for good reasons.
The cs5535-mfgpt chip is nasty because it has no reliable reset function.
Therefore by unloading and loading the module again bad things can happen.

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/