linux-kernel - Re: [PATCHSET] sysfs: use seq_file and unify regular and bin file handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Sep 2013 23:03:50 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Kay Sievers <kay@...y.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCHSET] sysfs: use seq_file and unify regular and bin file handling

On Sat, Sep 28, 2013 at 4:15 PM, Tejun Heo <tj@...nel.org> wrote:
> Hey, again.
>
> On Sat, Sep 28, 2013 at 05:49:30PM -0400, Tejun Heo wrote:
>>  0001-sysfs-remove-unused-sysfs_buffer-pos.patch
>>  0002-sysfs-remove-sysfs_buffer-needs_read_fill.patch
>>  0003-sysfs-remove-sysfs_buffer-ops.patch
>>  0004-sysfs-add-sysfs_open_file_mutex.patch
>>  0005-sysfs-rename-sysfs_buffer-to-sysfs_open_file.patch
>>  0006-sysfs-add-sysfs_open_file-sd-and-file.patch
>>  0007-sysfs-use-transient-write-buffer.patch
>>  0008-sysfs-use-seq_file-when-reading-regular-files.patch
>>  0009-sysfs-prepare-llseek-path-for-unified-regular-bin-fi.patch
>>  0010-sysfs-prepare-path-write-for-unified-regular-bin-fil.patch
>>  0011-sysfs-prepare-read-path-for-unified-regular-bin-file.patch
>>  0012-sysfs-copy-bin-mmap-support-from-fs-sysfs-bin.c-to-f.patch
>>  0013-sysfs-prepare-open-path-for-unified-regular-bin-file.patch
>>  0014-sysfs-merge-regular-and-bin-file-handling.patch
>
> On the second thought, 0011 seems too dangerous, especially for pci IO
> BAR regions.  Grumble, looks like I'll have to break out the bin read
> path.  Please ignore patches >= 0009.  I'll update them and repost.

I don't pretend to understand sysfs or the issue you tripped over with
PCI I/O BAR regions.  But we had a long discussion about those files
[1] last spring, and I'm pretty convinced that it was a mistake to add
them in their current form, and I would support an attempt to rework
them.  We had some ideas about how to do that, but I think everybody
lost interest before anything happened.

Bjorn

[1] http://lkml.kernel.org/r/20130316213519.2974.38954.stgit@amt.stowe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/