lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Oct 2013 07:46:46 +0200 From: Ingo Molnar <mingo@...nel.org> To: Zhang Yanfei <zhangyanfei.yes@...il.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, "H. Peter Anvin" <hpa@...or.com>, Tejun Heo <tj@...nel.org>, Lai Jiangshan <laijs@...fujitsu.com>, Wen Congyang <wency@...fujitsu.com>, isimatu.yasuaki@...fujitsu.com, izumi.taku@...fujitsu.com, Zhang Yanfei <zhangyanfei@...fujitsu.com>, Tang Chen <tangchen@...fujitsu.com>, linux-doc@...r.kernel.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Linux MM <linux-mm@...ck.org>, imtangchen@...il.com Subject: Re: [PATCH -mm] mm, memory-hotpulg: Rename movablenode boot option to movable_node * Zhang Yanfei <zhangyanfei.yes@...il.com> wrote: > @@ -153,11 +153,18 @@ config MOVABLE_NODE > help > Allow a node to have only movable memory. Pages used by the kernel, > such as direct mapping pages cannot be migrated. So the corresponding > + memory device cannot be hotplugged. This option allows the following > + two things: > + - When the system is booting, node full of hotpluggable memory can > + be arranged to have only movable memory so that the whole node can > + be hotplugged. (need movable_node boot option specified). So this is _exactly_ what I complained about earlier: why is the movable_node boot option needed to get that extra functionality? It's clearly not just a drop-in substitute to CONFIG_MOVABLE_NODE but extends its functionality, right? Boot options are _very_ poor user interface. If you don't want to enable it by default then turn this sub-functionality into CONFIG_MOVABLE_NODE_AUTO and keep it default-off - but don't pretend that this is only about CONFIG_MOVABLE_NODE alone - it isnt: as described above the 'movable_node' is needed for the full functionality to be available! Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists