linux-kernel - Re: [PATCH 3/7] arm: dts: dra7: add bandgap entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 1 Oct 2013 21:28:07 -0400
From:	Eduardo Valentin <eduardo.valentin@...com>
To:	Nishanth Menon <nm@...com>
CC:	Eduardo Valentin <eduardo.valentin@...com>,
	<swarren@...dotorg.org>, <pawel.moll@....com>,
	<mark.rutland@....com>, <ian.campbell@...rix.com>,
	<rob.herring@...xeda.com>, <linux@...ck-us.net>,
	<rui.zhang@...el.com>, <grant.likely@...aro.org>,
	<linux-pm@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<lm-sensors@...sensors.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/7] arm: dts: dra7: add bandgap entry

On 01-10-2013 18:46, Nishanth Menon wrote:
> On 14:32-20131001, Eduardo Valentin wrote:
>> This patch adds bandgap IP entry on DRA7 dtsi device tree file.
>>
>> Signed-off-by: Eduardo Valentin <eduardo.valentin@...com>
>> ---
>>  arch/arm/boot/dts/dra7.dtsi | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>> index 3a746c2..4e9b159 100644
>> --- a/arch/arm/boot/dts/dra7.dtsi
>> +++ b/arch/arm/boot/dts/dra7.dtsi
>> @@ -53,6 +53,18 @@
>>  		};
>>  	};
>>  
>> +	bandgap: bandgap {
> 	would you like to follow bandgap: bandgap@...021e0 convention?
> Also, could you move it under ocp?
> I already commented about this previously here: 
> https://lkml.org/lkml/2013/9/27/300

yes, this can be done.

> 
>> +		reg = <0x4a0021e0 0xc
>> +			0x4a00232c 0xc
>> +			0x4a002380 0x2c
>> +			0x4a0023C0 0x3c
>> +			0x4a002564 0x8
>> +			0x4a002574 0x50>;
>> +		compatible = "ti,dra752-bandgap";
>> +		interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>;
>> +		#thermal-sensor-cells = <1>;
>> +	};
>> +
>>  	gic: interrupt-controller@...11000 {
>>  		compatible = "arm,cortex-a15-gic";
>>  		interrupt-controller;


-- 
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin


Download attachment "signature.asc" of type "application/pgp-signature" (296 bytes)