linux-kernel - Re: [PATCH 18/21] cpuidle: don't call poll_idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Oct 2013 16:03:42 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Lists linaro-kernel <linaro-kernel@...ts.linaro.org>,
	Patch Tracking <patches@...aro.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 18/21] cpuidle: don't call poll_idle_init() for every cpu

On 26 September 2013 13:58, Daniel Lezcano <daniel.lezcano@...aro.org> wrote:
> Yes, certainly and that will impact also the menu select governor function:
>
>  ...
>
>         /*
>          * We want to default to C1 (hlt), not to busy polling
>          * unless the timer is happening really really soon.
>          */
>         if (data->expected_us > 5 &&
>             !drv->states[CPUIDLE_DRIVER_STATE_START].disabled &&
>                 dev->states_usage[CPUIDLE_DRIVER_STATE_START].disable == 0)
>                 data->last_state_idx = CPUIDLE_DRIVER_STATE_START;
>
>         /*
>          * Find the idle state with the lowest power while satisfying
>          * our constraints.
>          */
>         for (i = CPUIDLE_DRIVER_STATE_START; i < drv->state_count; i++) {
>                 struct cpuidle_state *s = &drv->states[i];
>                 struct cpuidle_state_usage *su = &dev->states_usage[i];
>
>                 if (s->disabled || su->disable)
>                         continue;
>                 if (s->target_residency > data->predicted_us)
>                         continue;
>                 if (s->exit_latency > latency_req)
>                         continue;
>                 if (s->exit_latency * multiplier > data->predicted_us)
>                         continue;
>
>                 data->last_state_idx = i;
>                 data->exit_us = s->exit_latency;
>         }

Hmm.. For now I will repost this patch as is and then you can go ahead
for this bigger change.. I wouldn't be able to do this change now, as I
would be rushing for my 2 weeks vacations :)

If this patch looked okay to you, can you please Ack it ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/