linux-kernel - Re: [PATCH 4/4] kconfig: remove unused definition from scanner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 03 Oct 2013 15:13:09 +0200
From:	Dirk Gouders <dirk@...ders.net>
To:	Martin Walch <walch.martin@....de>
Cc:	"Yann E. MORIN" <yann.morin.1998@...e.fr>,
	linux-kbuild@...r.kernel.org, Michal Marek <mmarek@...e.cz>,
	Jiri Kosina <trivial@...nel.org>,
	Arve Hjønnevåg <arve@...roid.com>,
	Benjamin Poirier <bpoirier@...e.de>,
	Wang YanQing <udknight@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jean Delvare <jdelvare@...e.de>,
	Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] kconfig: remove unused definition from scanner

Martin Walch <walch.martin@....de> writes:

> On Wednesday 02 October 2013 08:57:54 Yann E. MORIN wrote:
>> On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote:
>> > I think you should also regenerate the scanner and add
>> > the new zconf.lex.c_shipped to this patch.
>> 
>> I think sending the re-generated parser as a separate patch helps
>> in reviewing. Ie. I'd prefer a fifth patch.
>> 
>> BTW, regenerating the parser can be done with:
>>     make REGENERATE_PARSERS=1 config
>
> Actually, I regenerated the scanner. However, the results did not change
> after applying the patch, because the definition that the patch removes
> (ws) is not used anywhere. It is only a cleanup.

Sorry, my review was too superficial.
I did downgrade my flex to see if your changes affect the scanner,
but I did not test it without your patch and also did not have a look in
what the changes are.

The changes I noticed here are probably related to the flex package I
use (on a Gentoo system) -- they even occur without your patch.  I'll
attach what I noticed in case someone is interested.

Dirk


View attachment "zconf.lex.c_shipped.patch" of type "text/plain" (584 bytes)