linux-kernel - Re: [PATCH v6 2/2] mmc: sdhci-msm: Initial support for MSM chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 5 Oct 2013 22:51:32 -0700
From:	Bjorn Andersson <bjorn@...o.se>
To:	Georgi Djakov <gdjakov@...sol.com>
Cc:	linux-mmc@...r.kernel.org, Chris Ball <cjb@...top.org>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	devicetree@...r.kernel.org, mark.rutland@....com,
	swarren@...dotorg.org, ian.campbell@...rix.com, rob@...dley.net,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org,
	Asutosh Das <asutoshd@...eaurora.org>,
	Venkat Gopalakrishnan <venkatg@...eaurora.org>,
	Sahitya Tummala <stummala@...eaurora.org>,
	Subhash Jadavani <subhashj@...eaurora.org>
Subject: Re: [PATCH v6 2/2] mmc: sdhci-msm: Initial support for MSM chipsets

Hi Georgi,

Thanks for working on this, unfortunately it seems like I need to port
the rpm regulators to be able to test this.
But I did find that...

On Fri, Sep 27, 2013 at 9:57 AM, Georgi Djakov <gdjakov@...sol.com> wrote:
> ...
> +static irqreturn_t sdhci_msm_pwr_irq(int irq, void *data)
> +{
> +       struct sdhci_msm_host *msm_host = (struct sdhci_msm_host *)data;
> ...
> +static int sdhci_msm_probe(struct platform_device *pdev)
> +{
> +       struct sdhci_host *host;
> +       struct sdhci_msm_host *msm_host;
> ...
> +       ret = devm_request_threaded_irq(&pdev->dev, msm_host->pwr_irq, NULL,
> +                                       sdhci_msm_pwr_irq, IRQF_ONESHOT,
> +                                       dev_name(&pdev->dev), host);
> ...

...sdhci_msm_pwr_irq() expects the data pointer to be msm_host, not
sdhci_host, so right now I only get a panic. So I suspect you mean
msm_host as the last param here.

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/