linux-kernel - [tip:sched/core] sched/rt: Remove redundant nr_cpus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 6 Oct 2013 07:04:19 -0700
From:	tip-bot for Shawn Bohrer <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, mgalbraith@...e.de, hpa@...or.com,
	mingo@...nel.org, peterz@...radead.org, sbohrer@...advisors.com,
	rostedt@...dmis.org, tglx@...utronix.de
Subject: [tip:sched/core] sched/rt: Remove redundant nr_cpus_allowed test

Commit-ID:  6bfa687c19b7ab8adee03f0d43c197c2945dd869
Gitweb:     http://git.kernel.org/tip/6bfa687c19b7ab8adee03f0d43c197c2945dd869
Author:     Shawn Bohrer <sbohrer@...advisors.com>
AuthorDate: Fri, 4 Oct 2013 14:24:53 -0500
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Sun, 6 Oct 2013 11:28:40 +0200

sched/rt: Remove redundant nr_cpus_allowed test

In 76854c7e8f3f4172fef091e78d88b3b751463ac6 ("sched: Use
rt.nr_cpus_allowed to recover select_task_rq() cycles") an
optimization was added to select_task_rq_rt() that immediately
returns when p->nr_cpus_allowed == 1 at the beginning of the
function.

This makes the latter p->nr_cpus_allowed > 1 check redundant,
which can now be removed.

Signed-off-by: Shawn Bohrer <sbohrer@...advisors.com>
Reviewed-by: Steven Rostedt <rostedt@...dmis.org>
Cc: Mike Galbraith <mgalbraith@...e.de>
Cc: tomk@...advisors.com
Cc: Peter Zijlstra <peterz@...radead.org>
Link: http://lkml.kernel.org/r/1380914693-24634-1-git-send-email-shawn.bohrer@gmail.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 kernel/sched/rt.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 01970c8..ceebfba 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -1213,8 +1213,7 @@ select_task_rq_rt(struct task_struct *p, int sd_flag, int flags)
 	 */
 	if (curr && unlikely(rt_task(curr)) &&
 	    (curr->nr_cpus_allowed < 2 ||
-	     curr->prio <= p->prio) &&
-	    (p->nr_cpus_allowed > 1)) {
+	     curr->prio <= p->prio)) {
 		int target = find_lowest_rq(p);
 
 		if (target != -1)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/