linux-kernel - Re: [PATCH] serial: tegra: remove deprecated IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 07 Oct 2013 11:07:11 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Michael Opdenacker <michael.opdenacker@...e-electrons.com>,
	gregkh@...uxfoundation.org, jslaby@...e.cz,
	Laxman Dewangan <ldewangan@...dia.com>
CC:	linux-serial@...r.kernel.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: tegra: remove deprecated IRQF_DISABLED

On 10/06/2013 12:30 AM, Michael Opdenacker wrote:
> This patch proposes to remove the use of the IRQF_DISABLED flag
> 
> It's a NOOP since 2.6.35 and it will be removed one day.

Laxman, care to comment? I'm not sure why the code explicitly specifies
IRQF_DISABLED if it's already a no-op. Perhaps the code expects
IRQF_DISABLED to do something, and hence there's some bug that needs to
be fixed because of it doesn't?

> Signed-off-by: Michael Opdenacker <michael.opdenacker@...e-electrons.com>
> ---
>  drivers/tty/serial/serial-tegra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c
> index 0489a2b..dfe79cc 100644
> --- a/drivers/tty/serial/serial-tegra.c
> +++ b/drivers/tty/serial/serial-tegra.c
> @@ -1018,7 +1018,7 @@ static int tegra_uart_startup(struct uart_port *u)
>  		goto fail_hw_init;
>  	}
>  
> -	ret = request_irq(u->irq, tegra_uart_isr, IRQF_DISABLED,
> +	ret = request_irq(u->irq, tegra_uart_isr, 0,
>  				dev_name(u->dev), tup);
>  	if (ret < 0) {
>  		dev_err(u->dev, "Failed to register ISR for IRQ %d\n", u->irq);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/