[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20131008084610.GB3295@gmail.com>
Date: Tue, 8 Oct 2013 10:46:10 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Jiri Olsa <jolsa@...hat.com>
Cc: linux-kernel@...r.kernel.org,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Arnaldo Carvalho de Melo <acme@...hat.com>,
Namhyung Kim <namhyung@...nel.org>,
David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 37/50] tools/perf/build: Improve printout-of
auto-detected features
* Jiri Olsa <jolsa@...hat.com> wrote:
> On Mon, Oct 07, 2013 at 01:56:30PM +0200, Ingo Molnar wrote:
>
> SNIP
>
> > +#
> > +# Only print out our features if we rebuilt the testcases or if a test failed:
> > +#
> > +ifeq ($(test-all-failed), 1)
> > + $(foreach feat,$(CORE_FEATURE_TESTS) DUMMY,$(call feature_print,$(feat)))
> > + $(info )
> > +endif
>
> found the DUMMY! what do I win? ;-)
:-)
So, this is a bit of a GNU Make mystery to me. If I have a failure for at
least one of the features, and if I leave out that DUMMY then I get this
printout:
... libperl: [ OFF ]
... libpython: [ on ]
... libpython-version: [ on ]
... libslang: [ on ]
... libunwind: [ on ]
... on-exit: [ on ]
... stackprotector: [ on ]
... stackprotector-all: [ on ]
GEN python/perf.so
Note how the last entry is missing: volatile-register-var.
If I add the DUMMY I get the full printout:
... libperl: [ OFF ]
... libpython: [ on ]
... libpython-version: [ on ]
... libslang: [ on ]
... libunwind: [ on ]
... on-exit: [ on ]
... stackprotector: [ on ]
... stackprotector-all: [ on ]
... volatile-register-var: [ on ]
GEN python/perf.so
Somehow GNU Make appears to be eating terminal ouput - or I might have
misunderstood something.
I hope it's the latter - but if it's the former then the DUMMY entry is
needed :-/
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists