linux-kernel - Re: [PATCH 15/52] tools/perf/build: Split out feature check: 'libelf-mmap'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Oct 2013 08:56:09 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	David Ahern <dsahern@...il.com>, Jiri Olsa <jolsa@...hat.com>,
	Ulrich Drepper <drepper@...il.com>
Subject: Re: [PATCH 15/52] tools/perf/build: Split out feature check:
 'libelf-mmap'


* Namhyung Kim <namhyung@...nel.org> wrote:

> On Tue,  8 Oct 2013 12:10:45 +0200, Ingo Molnar wrote:
> > @@ -202,7 +203,7 @@ ifndef NO_LIBELF
> >    CFLAGS += -DHAVE_LIBELF_SUPPORT
> >    FLAGS_LIBELF=$(CFLAGS) $(LDFLAGS) $(EXTLIBS)
> >  
> > -  ifeq ($(call try-cc,$(SOURCE_ELF_MMAP),$(FLAGS_LIBELF),-DHAVE_LIBELF_MMAP_SUPPORT),y)
> > +  ifeq ($(feature-libelf-mmap), 1)
> >      CFLAGS += -DHAVE_LIBELF_MMAP_SUPPORT
> >    endif
> >  
> > @@ -227,8 +228,7 @@ endif # NO_LIBELF
> >  
> >  ifndef NO_LIBELF
> >    CFLAGS += -DHAVE_LIBELF_SUPPORT
> > -  FLAGS_LIBELF=$(CFLAGS) $(LDFLAGS) $(EXTLIBS)
> > -  ifeq ($(call try-cc,$(SOURCE_ELF_MMAP),$(FLAGS_LIBELF),-DHAVE_LIBELF_MMAP_SUPPORT),y)
> > +  ifeq ($(feature-libelf-mmap), 1)
> >      CFLAGS += -DHAVE_LIBELF_MMAP_SUPPORT
> >    endif # try-cc
> >  endif # NO_LIBELF
> 
> As Ulrich Drepper reported, it seems that this hunk is duplicate.

This was pre-existing, but indeed it's an unnecessary duplication. I'll 
send a patch in a separate mail.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/