linux-kernel - Re: [PATCH] sysfs/bin: Fix size handling overflow for bin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Oct 2013 10:40:11 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Tejun Heo <tj@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] sysfs/bin: Fix size handling overflow for bin_attribute

On Thu, Oct 10, 2013 at 10:38:47AM -0700, Greg KH wrote:
> On Thu, Oct 10, 2013 at 06:03:55PM +1100, Benjamin Herrenschmidt wrote:
> > While looking at the code, I noticed that bin_attribute read() and write()
> > ops copy the inode size into an int for futher comparisons.
> > 
> > Some bin_attributes can be fairly large. For example, pci creates some for
> > BARs set to the BAR size and giant BARs are around the corner, so this is
> > going to break something somewhere eventually.
> > 
> > Let's use the right type.
> > 
> > Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> 
> This file (fs/sysfs/bin.c) is no longer in linux-next as Tejun merged it
> with the other file handling code in sysfs, to remove a bunch of
> duplicated logic.
> 
> So, could you look at linux-next and see if this is still an issue there
> or not?

Ah, nevermind, I just looked, and it still is an issue there, I'll
hand-edit the patch to apply properly, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/