linux-kernel - Re: [PATCH 1/1] support new huawei devices in option.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Oct 2013 17:11:14 -0500
From:	Dan Williams <dcbw@...hat.com>
To:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc:	"Fangxiaozhi (Franko)" <fangxiaozhi@...wei.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Heyongquan <heyongquan@...wei.com>,
	Wangyuhua <yuhua.wang@...wei.com>,
	"Yili (Neil)" <neil.yi@...wei.com>
Subject: Re: [PATCH 1/1] support new huawei devices in option.c

On Fri, 2013-10-11 at 13:57 -0700, gregkh@...uxfoundation.org wrote:
> On Fri, Oct 11, 2013 at 03:48:21AM +0000, Fangxiaozhi (Franko) wrote:
> > 1. Add new supporting declarations to option.c, to support Huawei new devices with new bInterfaceSubClass value.
> > Signed-off-by: fangxiaozhi <huananhu@...wei.com>
> 
> In the future, can you use an email client that doesn't turn tabs into
> spaces, so I don't have to edit the patch by hand?
> 
> Also:
> 
> > + { USB_VENDOR_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0xff, 0x03, 0x01) },
> > + { USB_VENDOR_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0xff, 0x03, 0x02) },
> 
> <snip>
> 
> That's a huge list of ids, is there any way we can just mark all of
> these as used by the device in an easier manner?
> 
> I'll take this for now, but I have a feeling that this list is just
> going to get worse over time, right?

This is very, very odd.  Note the (ab)use of tons of subclass/protocol
numbers here to match devices instead of VID/PID.  Perhaps Huawei is
actually *running out* of PIDs or something?  There's no way every
single one of these devices actually speaks a different comm protocol on
these USB interfaces.  There has to be a reason that Huawei is now using
subclass/protocol for device matching instead of VID/PID like everyone
else is...

That said, I'm not sure there's much we can do about it.  But it still
raises one of my eyebrows up to the ceiling.

Dan

> thanks,
> 
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/