linux-kernel - Re: [PATCH] gpio/lynxpoint: check if the interrupt is enabled in IRQ handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 11 Oct 2013 14:09:40 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio/lynxpoint: check if the interrupt is enabled in IRQ
 handler

On Fri, Oct 11, 2013 at 12:57:37PM +0200, Linus Walleij wrote:
> On Tue, Oct 1, 2013 at 4:35 PM, Mika Westerberg
> <mika.westerberg@...ux.intel.com> wrote:
> 
> > Checking LP_INT_STAT is not enough in the interrupt handler because its
> > contents get updated regardless of whether the pin has interrupt enabled or
> > not. This causes the driver to loop forever for GPIOs that are pulled up.
> >
> > Fix this by checking the interrupt enable bit for the pin as well.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> 
> Patch applied for fixes with Mathias ACK.

Thanks!

> Should this be tagged for -stable as well?

Yes, please. I think starting from 3.9 when this driver was merged.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/