linux-kernel - [RFC][PATCH 3/7] sched: power: go_faster/slower power driver hints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Oct 2013 18:19:13 +0100
From:	Morten Rasmussen <morten.rasmussen@....com>
To:	mingo@...nel.org, peterz@...radead.org
Cc:	pjt@...gle.com, arjan@...ux.intel.com, rjw@...k.pl,
	dirk.j.brandewie@...el.com, vincent.guittot@...aro.org,
	alex.shi@...aro.org, preeti@...ux.vnet.ibm.com, efault@....de,
	corbet@....net, tglx@...utronix.de, catalin.marinas@....com,
	morten.rasmussen@....com, linux-kernel@...r.kernel.org,
	linaro-kernel@...ts.linaro.org
Subject: [RFC][PATCH 3/7] sched: power: go_faster/slower power driver hints

Adds power driver hints at task enqueue/dequeue and at the sched tick if
the new cpu load doesn't match the current cpu capacity. The optional hint
argument of go_faster/slower calls is currently unused. It is meant to
give the power driver a rough estimate of how much more/less cpu capacity
is needed. The power driver may ignore this and the go_faster/slower call
completely.

Signed-off-by: Morten Rasmussen <morten.rasmussen@....com>
---
 kernel/sched/fair.c  |   30 ++++++++++++++++++++++++++++++
 kernel/sched/sched.h |   18 ++++++++++++++++++
 2 files changed, 48 insertions(+)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index edba1bb..50ae0ce 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2852,6 +2852,31 @@ static inline void hrtick_update(struct rq *rq)
 }
 #endif
 
+#ifdef CONFIG_SCHED_POWER
+static unsigned long weighted_cpuload(const int cpu);
+static unsigned long power_of(int cpu);
+
+static inline void inc_cpu_capacity(int cpu)
+{
+	if (weighted_cpuload(cpu) > power_of(cpu))
+		go_faster(cpu, 0);
+}
+
+static inline void dec_cpu_capacity(int cpu)
+{
+	if (weighted_cpuload(cpu) < power_of(cpu))
+		go_slower(cpu, 0);
+}
+#else
+static inline void inc_cpu_capacity(int cpu)
+{
+}
+
+static inline void dec_cpu_capacity(int cpu)
+{
+}
+#endif
+
 /*
  * The enqueue_task method is called before nr_running is
  * increased. Here we update the fair scheduling stats and
@@ -2897,6 +2922,8 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags)
 		update_rq_runnable_avg(rq, rq->nr_running);
 		inc_nr_running(rq);
 	}
+
+	inc_cpu_capacity(task_cpu(p));
 	hrtick_update(rq);
 }
 
@@ -2958,6 +2985,8 @@ static void dequeue_task_fair(struct rq *rq, struct task_struct *p, int flags)
 		dec_nr_running(rq);
 		update_rq_runnable_avg(rq, 1);
 	}
+
+	dec_cpu_capacity(task_cpu(p));
 	hrtick_update(rq);
 }
 
@@ -5743,6 +5772,7 @@ static void run_rebalance_domains(struct softirq_action *h)
 	 */
 	nohz_idle_balance(this_cpu, idle);
 
+	inc_cpu_capacity(this_cpu);
 	power_late_callback(this_cpu);
 }
 
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 907a967..88e7968 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -1367,8 +1367,26 @@ static inline u64 irq_time_read(int cpu)
 
 #ifdef CONFIG_SCHED_POWER
 extern void power_late_callback(int cpu);
+extern int at_max_capacity(int cpu);
+extern int go_faster(int cpu, int hint);
+extern int go_slower(int cpu, int hint);
 #else
 static inline void power_late_callback(int cpu)
 {
 }
+
+static inline int at_max_capacity(int cpu)
+{
+	return 1;
+}
+
+static inline int go_faster(int cpu, int hint)
+{
+	return 0;
+}
+
+static inline int go_slower(int cpu, int hint)
+{
+	return 0;
+}
 #endif /* CONFIG_SCHED_POWER */
-- 
1.7.9.5


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/