lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 Oct 2013 17:06:05 -0700 From: Greg KH <gregkh@...uxfoundation.org> To: Matthias Beyer <mail@...ermatthias.de> Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 4/6] drivers: usb: core: devio.c: Coding style fixes On Thu, Oct 10, 2013 at 11:41:30PM +0200, Matthias Beyer wrote: > @@ -1838,9 +1838,10 @@ static int proc_ioctl(struct dev_state *ps, struct usbdevfs_ioctl *ctl) > return -ENODEV; > } > > - if (ps->dev->state != USB_STATE_CONFIGURED) > + if (ps->dev->state != USB_STATE_CONFIGURED) { > retval = -EHOSTUNREACH; > - else if (!(intf = usb_ifnum_to_if(ps->dev, ctl->ifno))) > + } > + else if (!(intf = usb_ifnum_to_if(ps->dev, ctl->ifno))) { > retval = -EINVAL; > else switch (ctl->ioctl_code) { I don't think you actually built the code after you made this change :( drivers/usb/core/devio.c: In function ‘proc_ioctl’: drivers/usb/core/devio.c:1844:2: error: expected ‘}’ before ‘else’ Please be more careful. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists