linux-kernel - Re: [PATCH 2/5] uprobes: Introduce __create_xol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Oct 2013 18:11:25 +0530
From:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Anton Arapov <aarapov@...hat.com>,
	David Smith <dsmith@...hat.com>,
	"Frank Ch. Eigler" <fche@...hat.com>,
	Martin Cermak <mcermak@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] uprobes: Introduce __create_xol_area()

* Oleg Nesterov <oleg@...hat.com> [2013-10-13 21:18:35]:

> No functional changes, preparation.
> 
> Extract the code which actually allocates/installs the new area
> into the new helper, __create_xol_area().
> 
> While at it remove the unnecessary "ret = ENOMEM" and "ret = 0"
> in xol_add_vma(), they both have no effect.
> 
> Cc: stable@...r.kernel.org # 3.9+
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>

Acked-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>

One nit below.

> 
>  /* Slot allocation for XOL */
> -static int xol_add_vma(struct xol_area *area)
> +static int xol_add_vma(struct mm_struct *mm, struct xol_area *area)
>  {
> -	struct mm_struct *mm = current->mm;
>  	int ret = -EALREADY;
> 
>  	down_write(&mm->mmap_sem);
>  	if (mm->uprobes_state.xol_area)
>  		goto fail;
> 
> -	ret = -ENOMEM;
> -	/* Try to map as high as possible, this is only a hint. */
> +		/* Try to map as high as possible, this is only a hint. */

Nit: This comment seems to be shifted unnecessarily.


-- 
Thanks and Regards
Srikar Dronamraju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/