linux-kernel - Re: [PATCH] device: Make dev_WARN/dev_WARN_ONCE print device as well as driver name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 24 Oct 2013 21:29:41 -0500
From:	Felipe Balbi <balbi@...com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	<linux-kernel@...r.kernel.org>, Felipe Balbi <balbi@...com>
Subject: Re: [PATCH] device: Make dev_WARN/dev_WARN_ONCE print device as well
 as driver name

On Thu, Oct 24, 2013 at 03:42:33PM -0600, Bjorn Helgaas wrote:
> dev_WARN() and dev_WARN_ONCE() are annoying because (1) they include
> only the driver name, not the device name, and (2) they print a spurious
> newline in the middle.  This results in messages like this that are less
> useful than they should be:
> 
>   [   40.094995] Device pcieport
>   disabling already-disabled device
> 
> This patch makes them work more like dev_printk().
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

Pretty cool, much nicer output indeed :-)

Reviewed-by: Felipe Balbi <balbi@...com>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)