linux-kernel - Re: [PATCH 1/3] thermal: bcm281xx: Add Temperature Monitor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 26 Oct 2013 01:47:40 -0500
From:	Kumar Gala <galak@...eaurora.org>
To:	Wendy Ng <wendy.ng@...adcom.com>
Cc:	"Rob Herring" <rob.herring@...xeda.com>,
	"Pawel Moll" <pawel.moll@....com>,
	"Mark Rutland" <mark.rutland@....com>,
	"Stephen Warren" <swarren@...dotorg.org>,
	"Ian Campbell" <ijc+devicetree@...lion.org.uk>,
	"Eduardo Valentin" <eduardo.valentin@...com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, "Christian Daudt" <bcm@...thebug.org>,
	"Markus Mayer" <mmayer@...adcom.com>,
	"Tim Kryger" <tim.kryger@...aro.org>,
	"Matt Porter" <matt.porter@...aro.org>
Subject: Re: [PATCH 1/3] thermal: bcm281xx: Add Temperature Monitor driver


On Oct 26, 2013, at 1:46 AM, Kumar Gala wrote:

> 
> On Oct 25, 2013, at 7:00 PM, Wendy Ng wrote:
> 
>> This adds the support for Temperature Monitor (TMON) driver for
>> Broadcom bcm281xx SoCs. This driver plugs into the Thermal Framework.
>> 
>> Note that this version of the TMON driver does support interrupt-driven
>> mode -- only polling-mode of the thermal framework can be used.
>> 
>> Signed-off-by: Wendy Ng <wendy.ng@...adcom.com>
>> Reviewed-by: Markus Mayer <mmayer@...adcom.com>
>> Reviewed-by: Christian Daudt <csd@...adcom.com>
>> Reviewed-by: Matt Porter <matt.porter@...aro.org>
>> Reviewed-by: Tim Kryger <tim.kryger@...aro.org>
>> ---
>> .../bindings/thermal/bcm-kona-thermal.txt          |   24 +++
>> drivers/thermal/Kconfig                            |   11 ++
>> drivers/thermal/Makefile                           |    1 +
>> drivers/thermal/bcm_kona_tmon.c                    |  173 ++++++++++++++++++++
>> 4 files changed, 209 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt
>> create mode 100644 drivers/thermal/bcm_kona_tmon.c
>> 
>> diff --git a/Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt b/Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt
>> new file mode 100644
>> index 0000000..225b898
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt
>> @@ -0,0 +1,24 @@
>> +* Broadcom Kona TMON bindings
>> +
>> +This version is for the Kona family of SoCs.  The TMON (Temperature Monitor)
>> +block in a Kona SoC device is used to measure the chip temperature at constant
>> +intervals.
>> +The TMON block asserts an interrupt if temperature exceeds a user programmed
>> +threshold value.  The TMON block would reset the entire device once it
>> +reaches a critical temperature which is also a programmable setting.
>> +
>> +Required properties:
>> +- compatible : "brcm,bcm11351-tmon", "brcm,kona-tmon"
>> +- reg : Address range of the thermal register
>> +- clocks : the clock signal that drives the TMON block
>> +- interrupts: the interrupt signal associated with the TMON block
>> +
>> +
>> +Example:
>> +	tmon@...08000 {
>> +		compatible = "brcm,bcm11351-tmon", "brcm,kona-tmon";
>> +		reg = <0x34008000 0x0024>;
>> +		clocks = <&tmon_1m_clk>;
>> +		interrupts = <GIC_SPI 183 IRQ_TYPE_LEVEL_HIGH>;
>> +		status = "disabled";
> 
> I'd remove the 'status' line from an example.
> 
>> +	};
> 
> Ack on the binding (beyond my minor nit pick on the status prop).
> 
> Acked-by: Kumar Gala <galak@...eaurora.org>
> 
> - k


After looking at your .dts{i} I see you've got a #thermal-sensor-cells prop, where is that documented?

- k

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/