linux-kernel - Re: [PATCH 02/11] asmlinkage: Make __iowrite32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 26 Oct 2013 12:02:21 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>, x86@...nel.org
Subject: Re: [PATCH 02/11] asmlinkage: Make __iowrite32_copy visible


* Andi Kleen <andi@...stfloor.org> wrote:

> From: Andi Kleen <ak@...ux.intel.com>
> 
> This is a assembler function on x86, so it should be visible.
> 
> Cc: x86@...nel.org
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> ---
>  include/linux/io.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

NAK for this and all the other patches, for two technical reasons:

- Please squash most of these trivial patches into a single patch 
  that also describes the context completely, at least the x86 and 
  core kernel ones that I'd apply within a single maintenance 
  domain.

- Please use the customary changelog style we use in the kernel:

   " Current code does (A), this has a problem when (B).
     We can improve this doing (C), because (D)."

Just saying 'because of LTO' is not enough, obviously. You need to 
talk about and explain things Andi. Being cryptic, mysterious and 
curt might work with some ladies, but it's outright harmful on lkml.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/