linux-kernel - Re: [PATCH 1/2] x86: unify copy_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Oct 2013 09:43:22 +0000
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Ingo Molnar" <mingo@...nel.org>
Cc:	"Peter Zijlstra" <a.p.zijlstra@...llo.nl>, <mingo@...e.hu>,
	<tglx@...utronix.de>, "Andrew Morton" <akpm@...ux-foundation.org>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	<arjan@...ux.intel.com>, <linux@...ck-us.net>,
	<linux-kernel@...r.kernel.org>, <hpa@...or.com>
Subject: Re: [PATCH 1/2] x86: unify copy_from_user() size checking

>>> On 26.10.13 at 12:31, Ingo Molnar <mingo@...nel.org> wrote:
> * Jan Beulich <JBeulich@...e.com> wrote:
>> I'd like to point out though that with __compiletime_object_size()
>> being restricted to gcc before 4.6, the whole construct is going to
>> become more and more pointless going forward. I would question
>> however that commit 2fb0815c9ee6b9ac50e15dd8360ec76d9fa46a2 ("gcc4:
>> disable __compiletime_object_size for GCC 4.6+") was really necessary,
>> and instead this should have been dealt with as is done here from the
>> beginning.
> 
> Can we now revert 2fb0815c9ee6?

Actually I'm afraid parisc would first need to follow the changes
done on x86 here, or else they'd run into (compile time) issues
(s390 and tile only emit warnings, i.e. would at worst suffer
cosmetically unless subtrees putting -Werror in place are
affected).

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/