linux-kernel - Re: [PATCH v3 3/3] msi: always unregister ->msi_kset within free_msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131029114534.GD24477@neilslaptop.think-freely.org>
Date:	Tue, 29 Oct 2013 07:45:34 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Veaceslav Falico <vfalico@...hat.com>
Cc:	linux-pci@...r.kernel.org, torvalds@...ux-foundation.org,
	tglx@...utronix.de, yinghai@...nel.org, Knut_Petersen@...nline.de,
	mingo@...nel.org, paulmck@...ux.vnet.ibm.com, fweisbec@...il.com,
	linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v3 3/3] msi: always unregister ->msi_kset within
 free_msi_irqs()

On Tue, Oct 29, 2013 at 11:30:32AM +0100, Veaceslav Falico wrote:
> Currently we create and populate ->msi_kset while allocating irqs in
> populate_msi_sysfs(), however if it fails and/or we want to free the
> entries - we don't always remove it, and we might have problems if we've
> failed to allocate irqs and try it again.
> 
> To fix that, move the unregister part to free_msi_irqs() and remove already
> existing ones. Also, verify if it was actually created - we don't always
> call free_msi_irqs() after populate_msi_sysfs().
> 
> CC: Bjorn Helgaas <bhelgaas@...gle.com>
> CC: Neil Horman <nhorman@...driver.com>
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> CC: linux-pci@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> Signed-off-by: Veaceslav Falico <vfalico@...hat.com>
Acked-by: Neil Horman <nhorman@...driver.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/