linux-kernel - Re: [PATCH 1/2] spi: add Intel Mid SSP driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Oct 2013 11:35:55 -0700
From:	Joe Perches <joe@...ches.com>
To:	David Cohen <david.a.cohen@...ux.intel.com>
Cc:	broonie@...nel.org, ning.li@...el.com,
	linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
	Fei Yang <fei.yang@...el.com>
Subject: Re: [PATCH 1/2] spi: add Intel Mid SSP driver

On Tue, 2013-10-29 at 11:30 -0700, David Cohen wrote:
> Hi Joe,
> 
> On 10/29/2013 11:19 AM, Joe Perches wrote:
> > On Tue, 2013-10-29 at 11:05 -0700, David Cohen wrote:
> >> This patch adds driver for ssp spi interface on Intel Mid platform.
> >
> > A few simple notes:
> >
> > Please consider using checkpatch.
> 
> I did and got no warnings. But haven't used --strict option.

Interesting.  I thought there was a return (foo);
statement that should have been marked, but I didn't
actually run checkpatch.

static inline u32 is_rx_fifo_empty(struct ssp_drv_context *sspc)
+{
+       return ((read_SSSR(sspc->ioaddr) & SSSR_RNE) == 0);
+}

This could be bool too


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/