linux-kernel - Re: [PATCH 2/2] simplefb: use write-combined remapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 30 Oct 2013 12:54:00 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	David Herrmann <dh.herrmann@...il.com>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	Tom Gundersen <teg@...m.no>,
	Alexandre Courbot <acourbot@...dia.com>,
	Stephen Warren <swarren@...dotorg.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	"linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>
Subject: Re: [PATCH 2/2] simplefb: use write-combined remapping

On 2013-10-30 09:49, David Herrmann wrote:
> Hi Tomi
> 
> Ping?

Thanks, queued this and the 1/2 patch for 3.13.

 Tomi

> 
> Thanks
> David
> 
> On Wed, Oct 2, 2013 at 4:58 PM, David Herrmann <dh.herrmann@...il.com> wrote:
>> Framebuffers shouldn't be cached and it is usually very uncommon to read
>> them. Therefore, use ioremap_wc() to get significant speed improvements on
>> systems which provide it. On all other systems it's aliased to
>> ioremap_nocache() which is also fine.
>>
>> Reported-by: Tom Gundersen <teg@...m.no>
>> Signed-off-by: David Herrmann <dh.herrmann@...il.com>
>> Tested-by: Tom Gundersen <teg@...m.no>
>> Tested-by: Alexandre Courbot <acourbot@...dia.com>
>> Tested-by: Stephen Warren <swarren@...dotorg.org>
>> ---
>>  drivers/video/simplefb.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c
>> index 74b016c..64db54a 100644
>> --- a/drivers/video/simplefb.c
>> +++ b/drivers/video/simplefb.c
>> @@ -219,8 +219,8 @@ static int simplefb_probe(struct platform_device *pdev)
>>
>>         info->fbops = &simplefb_ops;
>>         info->flags = FBINFO_DEFAULT | FBINFO_MISC_FIRMWARE;
>> -       info->screen_base = ioremap(info->fix.smem_start,
>> -                                   info->fix.smem_len);
>> +       info->screen_base = ioremap_wc(info->fix.smem_start,
>> +                                      info->fix.smem_len);
>>         if (!info->screen_base) {
>>                 framebuffer_release(info);
>>                 return -ENODEV;
>> --
>> 1.8.4
>>



Download attachment "signature.asc" of type "application/pgp-signature" (902 bytes)