| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Oct 2013 10:44:16 -0200 From: Geyslan Gregório Bem <geyslan@...il.com> To: Matt Fleming <matt@...sole-pimps.org> Cc: matthew.garrett@...ula.com, Jeremy Kerr <jk@...abs.org>, matt.fleming@...el.com, linux-efi@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, kernel-br <kernel-br@...glegroups.com> Subject: Re: [PATCH] efivarfs: 'efivarfs_file_write' function reorganization 2013/10/30 Matt Fleming <matt@...sole-pimps.org>: > On Mon, 14 Oct, at 03:37:17PM, Geyslan G. Bem wrote: >> This reorganization: >> >> Adds 'attrsize' variable to make the code cleaner and more >> understandable, replacing all 'sizeof(attributes)'. >> >> Removes 'bytes' prior assignment due this new approach. >> >> Uses 'memdup_user' instead 'kmalloc' + 'copy_from_user'. >> >> Signed-off-by: Geyslan G. Bem <geyslan@...il.com> >> --- >> fs/efivarfs/file.c | 23 +++++++++-------------- >> 1 file changed, 9 insertions(+), 14 deletions(-) > > Hmm.. I'm not convinced this is much of an improvement. I think removing > 'sizeof(attributes)' actually makes the code harder to read. > > -- > Matt Fleming, Intel Open Source Technology Center Do you want that I undo that? I aggre that the variable use only reduces the line code. -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists