linux-kernel - Re: [PATCH-next v3] kernel/system_certificate.S: use real contents instead of macro GLOBAL()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Oct 2013 08:47:15 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	David Howells <dhowells@...hat.com>
CC:	Joern Rennecke <joern.rennecke@...ecosm.com>,
	James Hogan <james.hogan@...tec.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Takashi Iwai <tiwai@...e.de>,
	Vineet Gupta <Vineet.Gupta1@...opsys.com>,
	"jeremy.bennett@...ecosm.com" <jeremy.bennett@...ecosm.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Claudiu Zissulescu <Claudiu.Zissulescu@...opsys.com>,
	Francois Bedard <Francois.Bedard@...opsys.com>,
	Max Filippov <jcmvbkbc@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH-next v3] kernel/system_certificate.S: use real contents
 instead of macro GLOBAL()

On 10/30/2013 08:57 PM, David Howells wrote:
> Chen Gang <gang.chen@...anux.com> wrote:
> 
>> If a macro is only used within 2 times, and also its contents are
>> within 2 lines, recommend to expand it to shrink code line.
>>
>> For our case, the macro is not portable either: some architectures'
>> assembler may use another character to mark newline in a macro (e.g.
>> '`' for arc), which will cause issue.
>>
>> If still want to use macro and let it portable enough, it will also
>> need include additional header file (e.g "#include <linux/linkage.h>",
>> although it also need be fixed).
> 
> Fine by me.
> 
> Applied.
> 
> 

Thanks.
-- 
Chen Gang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/