linux-kernel - Re: linux-next: Tree for Oct 31 (input & leds)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Oct 2013 19:02:49 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Samuel Thibault <samuel.thibault@...-lyon.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	akpm@...cata.ens-lyon.org
Subject: Re: linux-next: Tree for Oct 31 (input & leds)

On 10/31/13 18:21, Samuel Thibault wrote:
> Randy Dunlap, le Thu 31 Oct 2013 11:04:59 -0700, a écrit :
>> On 10/31/13 03:00, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20131030:
>>>
>>> The net-next tree gained a conflict against the net tree.
>>>
>>> The devicetree tree gained a conflict against the crypto tree.
>>>
>>> The tty tree gained a build failure so I used the version from
>>> next-20131030.
>>>
>>> The arm-soc tree gained conflicts against the devicetree tree.
>>
>>
>> on i386, when both
>> CONFIG_INPUT=m
>> CONFIG_INPUT_LEDS=m
>>
>> ERROR: "input_led_disconnect" [drivers/input/input-core.ko] undefined!
>> ERROR: "input_led_connect" [drivers/input/input-core.ko] undefined!
>>
>>
>> Full randconfig file is attached.
> 
> Ah, right, in that config an export is needed, here is a patch.
> 
> Samuel
> 
> 
> 
> Export input led symbols for input core module.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@...-lyon.org>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> 
> --- drivers/input/leds.c.orig	2013-11-01 01:43:38.889584308 +0100
> +++ drivers/input/leds.c	2013-11-01 01:44:02.060916781 +0100
> @@ -210,6 +210,7 @@
>  	input_led_delete(dev);
>  	return error;
>  }
> +EXPORT_SYMBOL_GPL(input_led_connect);
>  
>  /* Disconnected input device. Clean it, and deregister now-useless VT LEDs
>   * and triggers.  */
> @@ -241,6 +242,7 @@
>  	}
>  	mutex_unlock(&vt_led_registered_lock);
>  }
> +EXPORT_SYMBOL_GPL(input_led_disconnect);
>  
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("User LED support for input layer");
> --


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/