lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 02 Nov 2013 08:10:33 +0400 From: Рустафа Джамурахметов <zbr@...emap.net> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Michal Nazarewicz <mina86@...a86.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] drivers: w1: make w1_slave::flags long to avoid casts Hi 01.11.2013, 23:30, "Andrew Morton" <akpm@...ux-foundation.org>: > set_bit() operates on longs. So if we do > > struct foo { > u32 a; > u32 b; > } f; > > ... > set_bit(0, (long *)&f.a); > ... > > then we'll scribble on f.b on a big-endian 64-bit machine. Argh, why would we just don't do that? Its in-memory field, it can be anything, I wouldn't be surprised if it even can be non-atomic because of proper locks already being held -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists