linux-kernel - Re: [PATCH -next] pinctrl: imx1: fix return value check in imx1_pinctrl_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 4 Nov 2013 12:50:44 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] pinctrl: imx1: fix return value check in imx1_pinctrl_core_probe()

On Thu, Oct 31, 2013 at 8:51 AM, Wei Yongjun <weiyj.lk@...il.com> wrote:

> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> In case of error, the function devm_ioremap_nocache() returns NULL
> pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Patch applied.

I don't know why I miss such things during review all the time :-(

Anyway it is great that you fix it up!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/