linux-kernel - RE: mei: cancel stall timers in mei

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Nov 2013 18:48:48 +0300 (MSK)
From:	Eugene Shatokhin <eugene.shatokhin@...alab.ru>
To:	Tomas Winkler <tomas.winkler@...el.com>
Cc:	Alexander Usyskin <alexander.usyskin@...el.com>,
	Nicol? Costanza <abitrules@...oo.it>,
	Alex Burmashev <alex.burmashev@...alab.ru>,
	LKML <linux-kernel@...r.kernel.org>
Subject: RE: mei: cancel stall timers in mei_reset

----- Original Message -----
> I would appreciate the full log and your .config 

I have attached the config and the log.

Meanwhile, I have found one suspicious place in the code that could be related: mei_reset() ignores the return value of mei_hw_start(). According to the logs, there was at least the following interesting call sequence before things went wrong:

mei_reset() => mei_hw_start() => .hw_start() callback, which is mei_me_hw_start() => mei_me_hw_ready_wait().

mei_me_hw_ready_wait() reported "wait hw ready failed" and returned -ETIMEDOUT, that error was propagated to mei_hw_start(). mei_reset(), however, does not check the return value of that function and goes on even if it returns an error: sets dev->dev_state to MEI_DEV_INIT_CLIENTS, calls mei_hbm_start_req(dev), etc.

I am not sure if this is intentional and if this is related to the problem, but still.

Regards,
Eugene
Download attachment "files.tar.bz2" of type "application/x-bzip-compressed-tar" (62338 bytes)