linux-kernel - Re: [PATCH 2/9] GenWQE: Remove option to select name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 05 Nov 2013 08:55:27 +1100
From:	Ryan Mallon <rmallon@...il.com>
To:	Frank Haverkamp <haver@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org
CC:	arnd@...db.de, gregkh@...uxfoundation.org, cody@...ux.vnet.ibm.com,
	schwidefsky@...ibm.com, utz.bacher@...ibm.com, mmarek@...e.cz,
	jsvogt@...ibm.com, MIJUNG@...ibm.com, cascardo@...ux.vnet.ibm.com,
	michael@...ra.de
Subject: Re: [PATCH 2/9] GenWQE: Remove option to select name

On 05/11/13 04:08, Frank Haverkamp wrote:
> Selecting interface names via configuration option is obsolete.

Don't do this. You are adding completely new code, so there is no reason
to post a patch full of code that is known to be incorrect, followed by
a set of patches fixing things. Just post the correct code to start
with. This makes the git history cleaner, and makes the code easier to
review.

You can use tools like git interactive rebase to split your work into
multiple patches. It should be quite easy for this because you mostly
just want to break down things to the file level, so even:

  git reset --soft <your-first-commit>

and then manually staging and commiting things from there would probably
be enough. You can use git add --interactive to stage individual file
hunks if you want to break things down further.

~Ryan

> 
> Signed-off-by: Frank Haverkamp <haver@...ux.vnet.ibm.com>
> ---
>  drivers/misc/genwqe/Kconfig        |   14 ++------------
>  include/linux/genwqe/genwqe_card.h |    6 +-----
>  2 files changed, 3 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/misc/genwqe/Kconfig b/drivers/misc/genwqe/Kconfig
> index bbf137d..6069d8c 100644
> --- a/drivers/misc/genwqe/Kconfig
> +++ b/drivers/misc/genwqe/Kconfig
> @@ -9,15 +9,5 @@ menuconfig GENWQE
>  	default n
>  	help
>  	  Enables PCIe card driver for IBM GenWQE accelerators.
> -          The user-space interface is described in
> -          include/linux/genwqe/genwqe_card.h.
> -
> -if GENWQE
> -
> -config GENWQE_DEVNAME
> -        string "Name for sysfs and device nodes"
> -	default "genwqe"
> -        help
> -          Select alternate name for sysfs and device nodes.
> -
> -endif
> +	  The user-space interface is described in
> +	  include/linux/genwqe/genwqe_card.h.
> diff --git a/include/linux/genwqe/genwqe_card.h b/include/linux/genwqe/genwqe_card.h
> index 2c33db1..ffed142 100644
> --- a/include/linux/genwqe/genwqe_card.h
> +++ b/include/linux/genwqe/genwqe_card.h
> @@ -41,11 +41,7 @@
>  #endif
>  
>  /* Basename of sysfs, debugfs and /dev interfaces */
> -#if defined(CONFIG_GENWQE_DEVNAME)
> -#  define GENWQE_DEVNAME CONFIG_GENWQE_DEVNAME
> -#else
> -#  define GENWQE_DEVNAME "genwqe"
> -#endif
> +#define GENWQE_DEVNAME "genwqe"
>  
>  #define GENWQE_TYPE_ALTERA_230		0x00 /* GenWQE4 Stratix-IV-230 */
>  #define GENWQE_TYPE_ALTERA_530		0x01 /* GenWQE4 Stratix-IV-530 */
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/