linux-kernel - Re: [PATCH] Avoid needless loop in sdhci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Nov 2013 10:56:27 +0800
From:	Dong Aisheng <dongas86@...il.com>
To:	Alexey Neyman <stilor@....net>
Cc:	Chris Ball <cjb@...top.org>,
	"open list:SECURE DIGITAL HO..." <linux-mmc@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Avoid needless loop in sdhci_irq()

On Wed, Nov 6, 2013 at 3:58 AM, Alexey Neyman <stilor@....net> wrote:
> Ignore Card Interrupt bit in the interrupt status if we already know that
> mmc_signal_sdio_irq() is going to be called at the end of sdhci_irq(). This
> avoids a needless loop in sdhci_irq() repeatedly reading interrupt status
> and doing nothing.
>
> Signed-off-by: Alexey Neyman <stilor@....net>

You need improve the patch title a bit, like:
mmc: sdhci: avoid needless loop for handle SDIO interrupts in sdhci_irq

Otherwise,
Acked-by: Dong Aisheng <b29396@...escale.com>

You could resend with my ack.

Regards
Dong Aisheng

> ---
>  drivers/mmc/host/sdhci.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 7a7fb4f..a83cd1b 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2491,6 +2491,14 @@ again:
>         result = IRQ_HANDLED;
>
>         intmask = sdhci_readl(host, SDHCI_INT_STATUS);
> +
> +       /*
> +        * If we know we'll call the driver to signal SDIO IRQ, disregard
> +        * further indications of Card Interrupt in the status to avoid a
> +        * needless loop.
> +        */
> +       if (cardint)
> +               intmask &= ~SDHCI_INT_CARD_INT;
>         if (intmask && --max_loops)
>                 goto again;
>  out:
> --
> 1.8.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/