linux-kernel - Re: [PATCH v2 03/11] rbtree/test: test rbtree_postorder_for_each_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Nov 2013 03:54:05 -0800
From:	Michel Lespinasse <walken@...gle.com>
To:	Cody P Schafer <cody@...ux.vnet.ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	EXT4 <linux-ext4@...r.kernel.org>, Jan Kara <jack@...e.cz>,
	rostedt@...dmis.org, Davidlohr Bueso <davidlohr.bueso@...com>,
	Seth Jennings <sjenning@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 03/11] rbtree/test: test rbtree_postorder_for_each_entry_safe()

On Wed, Nov 6, 2013 at 5:42 PM, Cody P Schafer <cody@...ux.vnet.ibm.com> wrote:
> Signed-off-by: Cody P Schafer <cody@...ux.vnet.ibm.com>
> ---
>  lib/rbtree_test.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/lib/rbtree_test.c b/lib/rbtree_test.c
> index df6c125..8b3c9dc 100644
> --- a/lib/rbtree_test.c
> +++ b/lib/rbtree_test.c
> @@ -114,6 +114,16 @@ static int black_path_count(struct rb_node *rb)
>         return count;
>  }
>
> +static void check_postorder_foreach(int nr_nodes)
> +{
> +       struct test_node *cur, *n;
> +       int count = 0;
> +       rbtree_postorder_for_each_entry_safe(cur, n, &root, rb)
> +               count++;
> +
> +       WARN_ON_ONCE(count != nr_nodes);
> +}
> +
>  static void check_postorder(int nr_nodes)
>  {
>         struct rb_node *rb;
> @@ -148,6 +158,7 @@ static void check(int nr_nodes)
>         WARN_ON_ONCE(count < (1 << black_path_count(rb_last(&root))) - 1);
>
>         check_postorder(nr_nodes);
> +       check_postorder_foreach(nr_nodes);
>  }
>
>  static void check_augmented(int nr_nodes)
> --
> 1.8.4.2

Looks reasonable if we need the rbtree_postorder_for_each_entry_safe
macro - but as I mentioned in 01/11, I would prefer if we could do
without that API.

Acked-by: Michel Lespinasse <walken@...gle.com>

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/