linux-kernel - [PATCH] misc: mic: dead code removal and minor cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat,  9 Nov 2013 05:13:42 +0100
From:	Michael Opdenacker <michael.opdenacker@...e-electrons.com>
To:	harshavardhan.r.kharche@...el.com, ashutosh.dixit@...el.com,
	gregkh@...uxfoundation.org, nikhil.rao@...el.com,
	sudeep.dutt@...el.com
Cc:	linux-kernel@...r.kernel.org,
	Michael Opdenacker <michael.opdenacker@...e-electrons.com>
Subject: [PATCH] misc: mic: dead code removal and minor cleanup

This removes the below test in drivers/misc/mic/card/mic_virtio.c:

if (!retry) {
...
}

This is dead code because the "retry" variable was set to 100
earlier in the same function.

This also removes dev_dbg statements to print the value of this variable.
That's not interesting to print the value of a variable which value is
always the same.

Signed-off-by: Michael Opdenacker <michael.opdenacker@...e-electrons.com>
---
 drivers/misc/mic/card/mic_virtio.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/misc/mic/card/mic_virtio.c b/drivers/misc/mic/card/mic_virtio.c
index 914cc9b2caad..0f387504b3fa 100644
--- a/drivers/misc/mic/card/mic_virtio.c
+++ b/drivers/misc/mic/card/mic_virtio.c
@@ -167,8 +167,6 @@ static void mic_reset_inform_host(struct virtio_device *vdev)
 		msleep(100);
 	};
 
-	dev_dbg(mic_dev(mvdev), "%s: retry: %d\n", __func__, retry);
-
 	/* Reset status to 0 in case we timed out */
 	iowrite8(0, &mvdev->desc->status);
 }
@@ -337,12 +335,6 @@ static int mic_find_vqs(struct virtio_device *vdev, unsigned nvqs,
 		msleep(100);
 	};
 
-	dev_dbg(mic_dev(mvdev), "%s: retry: %d\n", __func__, retry);
-	if (!retry) {
-		err = -ENODEV;
-		goto error;
-	}
-
 	return 0;
 error:
 	mic_del_vqs(vdev);
-- 
1.8.1.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/