linux-kernel - Re: [OPW kernel] Re: [PATCH v10] Staging: zram: Fix memory leak by refcount mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Nov 2013 21:26:15 +0530
From:	Rashika Kheria <rashika.kheria@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	opw-kernel <opw-kernel@...glegroups.com>,
	Minchan Kim <minchan@...nel.org>,
	Jiang Liu <jiang.liu@...wei.com>,
	Nitin Gupta <ngupta@...are.org>,
	Jerome Marchand <jmarchand@...hat.com>,
	Linux-Kernel <linux-kernel@...r.kernel.org>,
	stable@...r.kernel.org
Subject: Re: [OPW kernel] Re: [PATCH v10] Staging: zram: Fix memory leak by
 refcount mismatch

On Sun, Nov 10, 2013 at 9:15 PM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> On Fri, Nov 01, 2013 at 07:36:09PM +0530, Rashika Kheria wrote:
>> As suggested by Minchan Kim and Jerome Marchand "The code in reset_store
>> get the block device (bdget_disk()) but it does not put it (bdput()) when
>> it's done using it. The usage count is therefore incremented but never
>> decremented."
>>
>> This patch also puts bdput() for all error cases.
>>
>> Acked-by: Minchan Kim <minchan@...nel.org>
>> Acked-by: Jerome Marchand <jmarchan@...hat.com>
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
>> ---
>>
>> This revision fixes the following issue of the previous revision-
>> Incorrect Subject Line
>
> I'm a bit confused now, I see three different zram patches from you,
> with different subjects, are they all now just in one patch, this one?
>
> Can you just send me the outstanding zram patches that you have gotten
> acks from that you want applied, as I'm lost here.
>
> thanks,
>
> greg "easily confused" k-h
>

Hi Greg,

You have already applied the rest two patches for this driver. This is
the only patch which is left.

But I think you might have problem applying this because there have
been changes in previous patches later i.e you applied v8 of this
series, while, maintainers later suggested to change more and hence v9
was also introduced.

Therefore, v9's patch 1 and v10 patch is correct to be applied in the tree.

Thanks,
-- 
Rashika Kheria
B.Tech CSE
IIIT Hyderabad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/