[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 11 Nov 2013 13:30:08 +0100
From: Pantelis Antoniou <panto@...oniou-consulting.com>
To: Ionut Nicu <ioan.nicu.ext@....com>
Cc: Grant Likely <grant.likely@...retlab.ca>,
Rob Herring <robherring2@...il.com>,
Stephen Warren <swarren@...dotorg.org>,
Matt Porter <matt.porter@...aro.org>,
Koen Kooi <koen@...inion.thruhere.net>,
Alison Chaiken <Alison_Chaiken@...tor.com>,
Dinh Nguyen <dinh.linux@...il.com>,
Jan Lubbe <jluebbe@...net.de>,
Alexander Sverdlin <alexander.sverdlin@....com>,
Michael Stickel <ms@...able.de>,
Guenter Roeck <linux@...ck-us.net>,
Dirk Behme <dirk.behme@...il.com>,
Alan Tull <delicious.quinoa@...il.com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Michael Bohan <mbohan@...eaurora.org>,
Michal Simek <monstr@...str.eu>,
Matt Ranostay <mranostay@...il.com>,
Joel Becker <jlbec@...lplan.org>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] DT: proc: Add runtime overlay interface in /proc
Hi Ionut,
On Nov 11, 2013, at 11:22 AM, Ionut Nicu wrote:
> Hi,
>
> On 08.11.2013 16:06, ext Pantelis Antoniou wrote:
>> Add a runtime interface to /proc to enable generic device tree overlay
>> usage.
>>
>
>> +
>> + /* start at 256K at first */
>> + if (od->alloc == 0)
>> + od->alloc = SZ_256K / 2;
>> +
>
> Same problem as Guenter reported. I have to include <linux/sizes.h> or otherwise
> the code will not build.
>
OK, I guess on my platform it gets implicitly included.
>> + rcu_read_lock();
>> + idr_for_each_entry(&overlay_idr, od, id) {
>> + seq_printf(m, "%d: %d bytes", id, od->size);
>
> For od->size we should use "%zu", otherwise there will be a compilation warning.
> At least I get one on mips64...
>
Both of these will be included on the next revision of the patchset.
> Otherwise, I've tested this and it works fine for me also.
>
> Thanks,
> Ionut
Regards
-- Pantelis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists