linux-kernel - Re: make oldnoconfig fix?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Nov 2013 10:55:37 -0800
From:	David Cohen <david.a.cohen@...ux.intel.com>
To:	"Yann E. MORIN" <yann.morin.1998@...e.fr>
CC:	linux-kbuild@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	mmarek@...e.cz, rostedt@...dmis.org
Subject: Re: make oldnoconfig fix?

On 11/11/2013 10:13 AM, Yann E. MORIN wrote:
> David, All,

Hi Yann,

>
> On 2013-11-11 10:11 -0800, David Cohen spake thusly:
>> Is there a plan to fix 'make oldnoconfig' option?
>> I currently have need to it :)
>> I've tracked a thread fixing 'make olddefconfig' where 'oldnoconfig'
>> option is reported as a known bug, right?
>
> Sorry, I don't understand what your problem is.

Maybe I assumed it was more 'known' then it actually is :)

>
> Care to explain in details what problem you have:
>    - what you start with
>    - what you do
>    - what you get
>    - what you expected

The bug with 'oldnoconfig' is: 'make oldnoconfig' is just an alias to
'olddefconfig'. Any non-existent config is defined with its default
value instead of 'N'.

I work with embedded platforms. I need to maintain a set of defconfigs
for different products (customers some times want tailored configs, so
creating a generic one isn't an option always).

In order to have full control of the .config generated out of
defconfigs, I don't allow any CONFIG_ to be selected implicitly. So
everytime a Kconfig is changed in our internal tree, we need to update
all defconfigs either with CONFIG_... = [y|n] or # CONFIG_... is not set

If I managed to get 'make oldnoconfig' working, I could not care about
# CONFIG_... is not set and internal and changes to defconfigs would be
easily to understand and review.

>
> So we can try to reproduce the issue and investigate what is wrong.

All we need to know is explained in this commit:

commit fb16d8912db5268f29706010ecafff74b971c58d
Author: Adam Lee <adam8157@...il.com>
Date:   Sat Sep 1 01:05:17 2012 +0800

     kconfig: replace 'oldnoconfig' with 'olddefconfig', and keep the 
old name as an alias

     As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, 'oldnoconfig' doesn't
     set new symbols to 'n', but instead sets it to their default values.

     So, this patch replaces 'oldnoconfig' with 'olddefconfig', stop making
     people confused, and keep the old name 'oldnoconfig' as an alias,
     because people already are dependent on its behavior with the
     counter-intuitive name.

     Signed-off-by: Adam Lee <adam8157@...il.com>
     Signed-off-by: Michal Marek <mmarek@...e.cz>


>
> Since you mention an existing thread, please add a pointer (URL) to
> this thread in the archives (Use: http://marc.info/?l=linux-kbuild ).

This is the thread I was talking about: 
http://comments.gmane.org/gmane.linux.kbuild.devel/8560

Master Yoda promised to fix it when the problem gets bigger :)

Br, David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/