[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 11 Nov 2013 20:47:21 +0100
From: Borislav Petkov <bp@...en8.de>
To: Takashi Iwai <tiwai@...e.de>
Cc: linux-kernel@...r.kernel.org, Prarit Bhargava <prarit@...hat.com>,
Ming Lei <ming.lei@...onical.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
x86@...nel.org, amd64-microcode@...64.org
Subject: Re: [PATCH v2 1/3] firmware: Introduce request_firmware_direct()
On Mon, Nov 11, 2013 at 06:30:08PM +0100, Takashi Iwai wrote:
> From: Takashi Iwai <tiwai@...e.de>
> Subject: [PATCH] firmware: Use bit flags instead of boolean combos
>
> More than two boolean arguments to a function are rather confusing and
> error-prone for callers. Let's make the behavior bit flags instead of
> triple combos.
>
> A nice suggestion by Borislav Petkov.
>
> Signed-off-by: Takashi Iwai <tiwai@...e.de>
> ---
> drivers/base/firmware_class.c | 49 ++++++++++++++++++++++++-------------------
> 1 file changed, 28 insertions(+), 21 deletions(-)
Yeah, looks good, thanks!
Acked-by: Borislav Petkov <bp@...e.de>
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists