[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 11 Nov 2013 13:44:20 -0700
From: David Ahern <dsahern@...il.com>
To: Ingo Molnar <mingo@...nel.org>
CC: Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
linux-kernel@...r.kernel.org, jolsa@...hat.com,
Frederic Weisbecker <fweisbec@...il.com>,
Peter Zijlstra <peterz@...radead.org>,
Namhyung Kim <namhyung@...nel.org>,
Mike Galbraith <efault@....de>,
Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 2/2] perf record: mmap output file - v4
On 11/11/13, 1:41 PM, Ingo Molnar wrote:
>
> * David Ahern <dsahern@...il.com> wrote:
>
>> On 11/11/13, 7:58 AM, Arnaldo Carvalho de Melo wrote:
>>>
>>>> Looks very clean now!
>>>
>>>> Acked-by: Ingo Molnar <mingo@...nel.org>
>>>
>>> Applied the prep patch, but waiting for v5 as stated by David when
>>> answering Jiri's concerns.
>>
>> I'll re-send - giving some time for comments on the use of
>> setjmp/longjmp to bounce out of memcpy and error exit when filesystem
>> runs out of space.
>
> Maybe that could be an add-on patch instead?
That's what Arnaldo and I were thinking.
>
> All the rest would already be an improvement, right?
Yes. The longjmp handles the out-of-space failure condition trying to
write the data to a file. With mmap writes you get a SIGBUS when the
filesystem is full and you need to bail out of the memcpy.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists