| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Nov 2013 13:20:17 +0800
From: kasim ling <kasimling@...il.com>
To: Rob Herring <robherring2@...il.com>
Cc: mark.rutland@....com, linux@....linux.org.uk,
swarren@...dotorg.org, ijc+devicetree@...lion.org.uk,
kgene.kim@...sung.com, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-samsung-soc@...r.kernel.org
Subject: Re: ARM: dts: add board dts file for EXYNOS4412 based TINY4412 board
On Wed, Nov 13, 2013 at 3:13 AM, Rob Herring <robherring2@...il.com> wrote:
> On 11/12/2013 09:02 AM, Alex Ling wrote:
>> Add a minimal board dts file for EXYNOS4412 based FriendlyARM's
>> TINY4412 board. This patch including adds the node to support
>> peripherals like UART, SD card on SDMMC2 port, and this patch
>> adds GPIO connected LEDS and configure its properties like
>> following:
>> LED1: use 'heartbeat' trigger, blinking while the board is running.
>> LED4: use 'mmc0' trigger, on when mmc0 is accessing.
>> LED2 and LED3 can be controlled from userspace.
>
> Please send patches with [PATCH] prefix.
Well noted. Thanks.
>
>> Signed-off-by: Alex Ling <kasimling@...il.com>
>> ---
>> arch/arm/boot/dts/Makefile | 1 +
>> arch/arm/boot/dts/exynos4412-tiny4412.dts | 89 +++++++++++++++++++++++++++++
>> 2 files changed, 90 insertions(+)
>> create mode 100644 arch/arm/boot/dts/exynos4412-tiny4412.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 802720e..91671a2 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -59,6 +59,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
>> exynos4412-odroidx.dtb \
>> exynos4412-origen.dtb \
>> exynos4412-smdk4412.dtb \
>> + exynos4412-tiny4412.dtb \
>> exynos4412-trats2.dtb \
>> exynos5250-arndale.dtb \
>> exynos5250-smdk5250.dtb \
>> diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts
>> new file mode 100644
>> index 0000000..78ace14
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts
>> @@ -0,0 +1,89 @@
>> +/*
>> + * FriendlyARM's Exynos4412 based TINY4412 board device tree source
>> + *
>> + * Copyright (c) 2013 Alex Ling <kasimling@...il.com>
>> + *
>> + * Device tree source file for FriendlyARM's TINY4412 board which is based on
>> + * Samsung's Exynos4412 SoC.
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> +*/
>> +
>> +/dts-v1/;
>> +#include "exynos4412.dtsi"
>> +
>> +/ {
>> + model = "FriendlyARM TINY4412 board based on Exynos4412";
>> + compatible = "friendlyarm,tiny4412", "samsung,exynos4412";
>
> The compatible string needs to be documented.
Could you please advise where this should be documented to? I'm not
sure if "Documentation/devicetree/bindings/arm/samsung-boards.txt" is
a proper place or not.
>
> Rob
>
>> +
>> + memory {
>> + reg = <0x40000000 0x40000000>;
>> + };
>> +
>> + leds {
>> + compatible = "gpio-leds";
>> + led1 {
>> + label = "led1:heart";
>> + gpios = <&gpm4 0 1>;
>> + default-state = "off";
>> + linux,default-trigger = "heartbeat";
>> + };
>> + led2 {
>> + label = "led2";
>> + gpios = <&gpm4 1 1>;
>> + default-state = "off";
>> + };
>> + led3 {
>> + label = "led3";
>> + gpios = <&gpm4 2 1>;
>> + default-state = "off";
>> + };
>> + led4 {
>> + label = "led4:mmc0";
>> + gpios = <&gpm4 3 1>;
>> + default-state = "off";
>> + linux,default-trigger = "mmc0";
>> + };
>> + };
>> +
>> + rtc@...70000 {
>> + status = "okay";
>> + };
>> +
>> + sdhci@...30000 {
>> + bus-width = <4>;
>> + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
>> + pinctrl-names = "default";
>> + status = "okay";
>> + };
>> +
>> + serial@...00000 {
>> + status = "okay";
>> + };
>> +
>> + serial@...10000 {
>> + status = "okay";
>> + };
>> +
>> + serial@...20000 {
>> + status = "okay";
>> + };
>> +
>> + serial@...30000 {
>> + status = "okay";
>> + };
>> +
>> + fixed-rate-clocks {
>> + xxti {
>> + compatible = "samsung,clock-xxti";
>> + clock-frequency = <0>;
>> + };
>> +
>> + xusbxti {
>> + compatible = "samsung,clock-xusbxti";
>> + clock-frequency = <24000000>;
>> + };
>> + };
>> +};
>>
>
BR,
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists