linux-kernel - Re: [PATCH 3.13-rc1] xen-blkfront: Silence pfn maybe-uninitialized warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Nov 2013 17:24:53 -0500
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Tim Gardner <tim.gardner@...onical.com>,
	xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
CC:	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	David Vrabel <david.vrabel@...rix.com>,
	"roger.pau@...rix.com" <roger.pau@...rix.com>
Subject: Re: [PATCH 3.13-rc1] xen-blkfront: Silence pfn maybe-uninitialized warning

Tim Gardner <tim.gardner@...onical.com> wrote:
>pfn cannot actually be used unless (!info->feature_persistent), nor is
>pfn accessed in get_grant() unless (!info->feature_persistent), but
>silence
>this warning anyway. gcc-4.8
>
>drivers/block/xen-blkfront.c: In function 'do_blkif_request':
>drivers/block/xen-blkfront.c:508:20: warning: 'pfn' may be used
>uninitialized in this function [-Wmaybe-uninitialized]
>     gnt_list_entry = get_grant(&gref_head, pfn, info);
>                    ^
>drivers/block/xen-blkfront.c:492:19: note: 'pfn' was declared here
>     unsigned long pfn;
>
>Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
>Cc: Boris Ostrovsky <boris.ostrovsky@...cle.com>
>Cc: David Vrabel <david.vrabel@...rix.com>
>Signed-off-by: Tim Gardner <tim.gardner@...onical.com>
>---
> drivers/block/xen-blkfront.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/block/xen-blkfront.c
>b/drivers/block/xen-blkfront.c
>index 432db1b..5f926de 100644
>--- a/drivers/block/xen-blkfront.c
>+++ b/drivers/block/xen-blkfront.c
>@@ -489,7 +489,7 @@ static int blkif_queue_request(struct request *req)
> 
> 			if ((ring_req->operation == BLKIF_OP_INDIRECT) &&
> 			    (i % SEGS_PER_INDIRECT_FRAME == 0)) {
>-				unsigned long pfn;
>+				unsigned long uninitialized_var(pfn);
> 
> 				if (segments)
> 					kunmap_atomic(segments);

I have a similar patch from Roger that sets pfn=0. 

Roger could you repost your patch please or if you feel that this patch makes sense then comment on it?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/