linux-kernel - Re: [PATCH 2/2] mm: create a separate slab for page->ptl allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 18 Nov 2013 14:04:17 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux MM <linux-mm@...ck.org>
Subject: Re: [PATCH 2/2] mm: create a separate slab for page->ptl allocation

Hi Geert,

On Sat, 16 Nov 2013 21:43:32 +0100 Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> On Thu, Nov 7, 2013 at 3:14 PM, Kirill A. Shutemov
> <kirill.shutemov@...ux.intel.com> wrote:
> > --- a/include/linux/mm.h
> > +++ b/include/linux/mm.h
> 
> > +static inline void pgtable_init(void)
> > +{
> > +       ptlock_cache_init();
> > +       pgtable_cache_init();
> > +}
> 
> sparc64defconfig:
> 
> include/linux/mm.h:1391:2: error: implicit declaration of function
> 'pgtable_cache_init' [-Werror=implicit-function-declaration]
> arch/sparc/include/asm/pgtable_64.h:978:13: error: conflicting types
> for 'pgtable_cache_init' [-Werror]
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/10040274/
> 
> Has this been in -next?

No, it hasn't :-(

> Probably it needs <asm/pgtable.h>.

Actually it is because on sparc64, asm/tlbflush_64.h includes linux/mm.h
(and asm/pgtable.h -> asm/pgtable_64.h -> asm/tlbflush.h ->
asm/tlbflush_64.h)

(see my other error report and I have reverted that commit from
linux-next today.)

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped