linux-kernel - RE: [PATCH 1/1] i2c-ismt: add the support of the I2C_SMBUS_I2C_BLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Nov 2013 00:09:08 +0000
From:	"Heasley, Seth" <seth.heasley@...el.com>
To:	"Valiquette, Robert" <robert.valiquette@...el.com>,
	"wsa@...-dreams.de" <wsa@...-dreams.de>,
	"nhorman@...driver.com" <nhorman@...driver.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"Ralston, James D" <james.d.ralston@...el.com>
Subject: RE: [PATCH 1/1] i2c-ismt: add the support of the
 I2C_SMBUS_I2C_BLOCK_DATA transaction type

> This patch adds the support of the I2C_SMBUS_I2C_BLOCK_DATA
> transaction type for the iSMT SMBus Controller.
> 
> Signed-off-by: Robert Valiquette <robert.valiquette@...el.com>
> ---
> --- a/drivers/i2c/busses/i2c-ismt.c	2013-11-14 11:36:15.830322000 -0500
> +++ b/drivers/i2c/busses/i2c-ismt.c	2013-11-14 16:01:56.532356000 -0500
> @@ -344,6 +344,7 @@
>  			data->word = dma_buffer[0] | (dma_buffer[1] << 8);
>  			break;
>  		case I2C_SMBUS_BLOCK_DATA:
> +		case I2C_SMBUS_I2C_BLOCK_DATA:
>  			memcpy(&data->block[1], dma_buffer, desc-
> >rxbytes);
>  			data->block[0] = desc->rxbytes;
>  			break;
> @@ -509,6 +510,41 @@
>  		}
>  		break;
> 
> +	case I2C_SMBUS_I2C_BLOCK_DATA:
> +		/* Make sure the lenght is valid */
> +		if (data->block[0] < 1)
> +			data->block[0] = 1;
> +
> +		if (data->block[0] > I2C_SMBUS_BLOCK_MAX)
> +			data->block[0] = I2C_SMBUS_BLOCK_MAX;
> +
> +		if (read_write == I2C_SMBUS_WRITE) {
> +			/* i2c Block Write */
> +			dev_dbg(dev, "I2C_SMBUS_I2C_BLOCK_DATA:
> WRITE\n");
> +			dma_size = data->block[0] + 1;
> +			dma_direction = DMA_TO_DEVICE;
> +			desc->wr_len_cmd = dma_size;
> +			desc->control |= ISMT_DESC_I2C;
> +			priv->dma_buffer[0] = command;
> +			memcpy(&priv->dma_buffer[1], &data->block[1],
> dma_size);
> +		} else {
> +			/* i2c Block Read */
> +			dev_dbg(dev, "I2C_SMBUS_I2C_BLOCK_DATA:
> READ\n");
> +			dma_size = data->block[0];
> +			dma_direction = DMA_FROM_DEVICE;
> +			desc->rd_len = dma_size;
> +			desc->wr_len_cmd = command;
> +			desc->control |= (ISMT_DESC_I2C |
> ISMT_DESC_CWRL);
> +			/*
> +			 * Per the "Table 15-15. I2C Commands",
> +			 * in the External Design Specification (EDS),
> +			 * (Document Number: 508084, Revision: 2.0),
> +			 * the _rw bit must be 0
> +			 */
> +			desc->tgtaddr_rw = ISMT_DESC_ADDR_RW(addr, 0);
> +		}
> +		break;
> +
>  	default:
>  		dev_err(dev, "Unsupported transaction %d\n",
>  			size);
> @@ -582,6 +618,7 @@
>  	       I2C_FUNC_SMBUS_WORD_DATA		|
>  	       I2C_FUNC_SMBUS_PROC_CALL		|
>  	       I2C_FUNC_SMBUS_BLOCK_DATA	|
> +	       I2C_FUNC_SMBUS_I2C_BLOCK		|
>  	       I2C_FUNC_SMBUS_PEC;
>  }
> 
Acked-by: Seth Heasley <seth.heasley@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/