linux-kernel - Re: IRQF_RESUME_EARLY and errors in dpm_suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 23 Nov 2013 22:25:48 +0100
From:	Heiko Stübner <heiko@...ech.de>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	Ian Campbell <ian.campbell@...rix.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Len Brown <len.brown@...el.com>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	Pavel Machek <pavel@....cz>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: IRQF_RESUME_EARLY and errors in dpm_suspend_noirq

Hi Laxman,

Am Mittwoch, 20. November 2013, 10:54:10 schrieb Laxman Dewangan:
> > I may be blind, but where get the early-irqs resumed in the error
> > path of dpm_suspend_noirq?
> > 
> > When a suspend_noirq callback returns an error, dpm_resume_noirq gets
> > called, which only calls resume_device_irqs while the
> > suspend_device_irqs call in dpm_suspend_noirq suspends all irqs. So it
> > does not seem that the early-irqs get resumed at all in this case.
> 
> I also faced same issue in our suspend failure path and posted fix
> sometime ago as
> https://lkml.org/lkml/2013/8/13/373
> 
> It is still under review.

>From the thread on lkml.org it looks like it got no reaction at all - maybe 
was just overlooked. So maybe it would be good to re-send it.

As it is not visible on lkml.org, did you also include stable@...nel.org, as 
the issue started in 2011?

> You can try this patch if it resolve the issue.

Your patch looks a lot more sophisticated than my current band-aid fix :-) by 
using the fact that irqs won't get resumed twice on their own.

So if you repost your patch you could add an

Acked-by: Heiko Stuebner <heiko@...ech.de>


Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/