linux-kernel - Re: [PATCH] max17042: Fix build errors caused by missing REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Nov 2013 09:40:04 +0900
From:	jonghwa3.lee@...sung.com
To:	Austin Boyle <boyle.austin@...il.com>
Cc:	Anton Vorontsov <anton@...msg.org>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Myungjoo Ham <myungjoo.ham@...sung.com>
Subject: Re: [PATCH] max17042: Fix build errors caused by missing REGMAP_I2C
 config

On 2013년 11월 24일 19:41, Austin Boyle wrote:

> max17042 now uses regmap interface but does not enable config option. This patch fixes the following build errors:
> 
> drivers/power/max17042_battery.c:661:15: error: variable ‘max17042_regmap_config’ has initializer but incomplete type
> drivers/power/max17042_battery.c:662:2: error: unknown field ‘reg_bits’ specified in initializer
> drivers/power/max17042_battery.c:662:2: warning: excess elements in struct initializer
> drivers/power/max17042_battery.c:662:2: warning: (near initialization for ‘max17042_regmap_config’)
> drivers/power/max17042_battery.c:663:2: error: unknown field ‘val_bits’ specified in initializer
> drivers/power/max17042_battery.c:663:2: warning: excess elements in struct initializer
> drivers/power/max17042_battery.c:663:2: warning: (near initialization for ‘max17042_regmap_config’)
> drivers/power/max17042_battery.c:664:2: error: unknown field ‘val_format_endian’ specified in initializer
> drivers/power/max17042_battery.c:664:23: error: ‘REGMAP_ENDIAN_NATIVE’ undeclared here (not in a function)
> drivers/power/max17042_battery.c:664:2: warning: excess elements in struct initializer
> drivers/power/max17042_battery.c:664:2: warning: (near initialization for ‘max17042_regmap_config’)
> drivers/power/max17042_battery.c: In function ‘max17042_probe’:
> drivers/power/max17042_battery.c:684:2: error: implicit declaration of function ‘devm_regmap_init_i2c’
> 
> Signed-off-by: Austin Boyle <boyle.austin@...il.com>
> ---
> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
> index 5e2054a..85ad58c 100644
> --- a/drivers/power/Kconfig
> +++ b/drivers/power/Kconfig
> @@ -196,6 +196,7 @@ config BATTERY_MAX17040
>  config BATTERY_MAX17042
>  	tristate "Maxim MAX17042/17047/17050/8997/8966 Fuel Gauge"
>  	depends on I2C
> +	select REGMAP_I2C
>  	help
>  	  MAX17042 is fuel-gauge systems for lithium-ion (Li+) batteries
>  	  in handheld and portable equipment. The MAX17042 is configured
> 


Sorry, It's my fault. Thanks.

Acked-by: Jonghwa Lee <jonghwa3.lee@...sung.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/