linux-kernel - Re: [PATCH V3 4/6] cpufreq: exynos: Use cpufreq_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 26 Nov 2013 20:06:22 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Lists linaro-kernel <linaro-kernel@...ts.linaro.org>,
	Patch Tracking <patches@...aro.org>,
	"cpufreq@...r.kernel.org" <cpufreq@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Nishanth Menon <nm@...com>,
	Stephen Warren <swarren@...dotorg.org>,
	Kgene Kim <kgene.kim@...sung.com>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	linux-tegra@...r.kernel.org, jinchoi@...adcom.com,
	Lan Tianyu <tianyu.lan@...el.com>,
	Sebastian Capella <sebastian.capella@...aro.org>,
	Jonghwan Choi <jhbird.choi@...sung.com>,
	Viresh Kumar <viresh.kumar@...aro.org>
Subject: Re: [PATCH V3 4/6] cpufreq: exynos: Use cpufreq_generic_suspend()

On 25 November 2013 19:41, Viresh Kumar <viresh.kumar@...aro.org> wrote:
> Currently we have implemented PM notifiers to disable/enable ->target() routines
> functionality during suspend/resume.
>
> Now we have support present in cpufreq core, lets use it.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---
>  drivers/cpufreq/exynos-cpufreq.c | 97 +++-------------------------------------
>  1 file changed, 6 insertions(+), 91 deletions(-)

Jonghwan Choi reported an issue with this patch. He asked me
to look at: 6e45eb

And so following diff is updated for this patch in my repo.. Will get
that fixed in V4:

diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
index 4b6e6a6..3f216da 100644
--- a/drivers/cpufreq/exynos-cpufreq.c
+++ b/drivers/cpufreq/exynos-cpufreq.c
@@ -22,8 +22,8 @@
 #include "exynos-cpufreq.h"

 static struct exynos_dvfs_info *exynos_info;
-
 static struct regulator *arm_regulator;
+static unsigned int locking_frequency;

 static int exynos_cpufreq_get_index(unsigned int freq)
 {
@@ -134,7 +134,7 @@ static int exynos_target(struct cpufreq_policy
*policy, unsigned int index)
 static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy)
 {
        policy->clk = exynos_info->cpu_clk;
-       policy->suspend_freq = clk_get_rate(exynos_info->cpu_clk) / 1000;
+       policy->suspend_freq = locking_frequency;
        return cpufreq_generic_init(policy, exynos_info->freq_table, 100000);
 }

@@ -182,6 +182,9 @@ static int __init exynos_cpufreq_init(void)
                goto err_vdd_arm;
        }

+       /* Done here as we want to capture boot frequency */
+       locking_frequency = clk_get_rate(exynos_info->cpu_clk) / 1000;
+
        if (!cpufreq_register_driver(&exynos_driver))
                return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/