linux-kernel - Re: clk: clk_round_rate() should return 0, not negative numbers, upon error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 25 Nov 2013 16:03:06 -0800
From:	Paul Walmsley <pwalmsley@...dia.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Mike Turquette <mturquette@...aro.org>
Subject: Re: clk: clk_round_rate() should return 0, not negative numbers,
 upon error

On 11/25/2013 04:01 PM, Russell King - ARM Linux wrote:
> On Mon, Nov 25, 2013 at 03:55:33PM -0800, Paul Walmsley wrote:
>> Update the documentation for clk_round_rate() to state that it should
>> return 0 rather than a negative error code when it encounters an
>> error.  This describes how the common clock framework currently works;
>> howeever, some clock code does not yet align to this.
>>
>> This change is to prepare for returning unsigned values from
>> clk_round_rate().
> You really ought to document why this is being changed here, to help
> sell the change to parties who are not aware of the background.
> Otherwise, it just looks like a gratuitous API change.

Will do and resend.

- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/