linux-kernel - Re: [PATCH v5 06/17] clk: at91: add PMC pll clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Nov 2013 13:48:43 -0800
From:	Mike Turquette <mturquette@...aro.org>
To:	Boris BREZILLON <b.brezillon@...rkiz.com>,
	"Rob Herring" <rob.herring@...xeda.com>,
	"Pawel Moll" <pawel.moll@....com>,
	"Mark Rutland" <mark.rutland@....com>,
	"Stephen Warren" <swarren@...dotorg.org>,
	"Ian Campbell" <ijc+devicetree@...lion.org.uk>,
	"Rob Landley" <rob@...dley.net>,
	"Andrew Victor" <linux@...im.org.za>,
	"Nicolas Ferre" <nicolas.ferre@...el.com>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@...osoft.com>,
	"Russell King" <linux@....linux.org.uk>,
	"Felipe Balbi" <balbi@...com>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	"Grant Likely" <grant.likely@...aro.org>,
	"Ludovic Desroches" <ludovic.desroches@...el.com>,
	"Josh Wu" <josh.wu@...el.com>,
	"Richard Genoud" <richard.genoud@...il.com>
Cc:	"Boris BREZILLON" <b.brezillon@...rkiz.com>,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH v5 06/17] clk: at91: add PMC pll clocks

Quoting Boris BREZILLON (2013-11-12 13:57:19)
> +static const struct clk_ops pll_ops = {
> +       .prepare = clk_pll_prepare,
> +       .is_prepared = clk_pll_is_ready,
> +       .disable = clk_pll_disable,
> +       .is_enabled = clk_pll_is_ready,
> +       .recalc_rate = clk_pll_recalc_rate,
> +       .round_rate = clk_pll_round_rate,
> +       .set_rate = clk_pll_set_rate,
> +};

Hi Boris,

It is a bit strange to see only a .prepare and .disable callback
populated. What happens if a driver calls clk_disable and then
clk_enable? You clock will still be disabled in hardware.

Regards,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/